Listing deployments from contracts instead of kvstore #2124
+782
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow/hide all deployments in vm_deployments_list
…ow/hide all deployments in k8s_deployments_list
- feat: Disable manage_domains for vms from another client
Test Cases
|
…e while loading k8s deployments
MohamedElmdary
requested review from
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R and
mohamedamer453
as code owners
…version 3 metadata
…om graphql to have these contracts
Store the contracts on static variable to be able to load the contract with different instances
Unify the metadata on grid client
Fix insert if found types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
most of the workloads are vms and we have 2 different clients to create these workloads, but client client was having his way of saving the deployment data to list them. So to be able to list workload from these clients on the dashboard, they have to use the same metadata stored on the contracts' data.
Changes
This PR lists the deployments (workloads) based on the contracts' data as this metadata is unified between the clients instead of the kvstore.
Related Issues
Checklist